greg/info-orbs
Watch
1
0
Fork
You've already forked info-orbs
 0
Code Issues 32 Pull requests 25 Projects Releases Packages Wiki Activity Actions

Implement automatic dimming capability #326

Open
shemers42 wants to merge 3 commits from shemers42/auto-dimming into dev
pull from: shemers42/auto-dimming
merge into: greg:dev
Conversation 1 Commits 3 Files changed 7 +273 -1
shemers42 commented 2025-07-19 00:20:41 +00:00 (Migrated from github.com)
Copy link

Add support for automatic dimming to adjust for changing room brightness. Requires a minor hardware modification described in ReadMe.txt .

This software change can be safely merged since it is disabled by default, and will have no effect unless AUTO_DIMMING_ENABLED is set to true in config.h

Closes #325

https://github.com/user-attachments/assets/0e3514b4-0801-445c-8f01-bd8083e6f8c7

Add support for automatic dimming to adjust for changing room brightness. Requires a minor hardware modification described in [ReadMe.txt](https://github.com/user-attachments/files/21323920/ReadMe.txt) . This software change can be safely merged since it is disabled by default, and will have no effect unless `AUTO_DIMMING_ENABLED` is set to `true` in config.h Closes #325 https://github.com/user-attachments/assets/0e3514b4-0801-445c-8f01-bd8083e6f8c7
ericthelin commented 2026-07-16 00:58:20 +00:00 (Migrated from github.com)
Copy link

This is an interesting idea. The PR is well done. But I question if we want to add code that requires a hardware modification. @brett-dot-tech I think this one is clearly in your court to give direction on.

This is an interesting idea. The PR is well done. But I question if we want to add code that requires a hardware modification. @brett-dot-tech I think this one is clearly in your court to give direction on.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin shemers42/auto-dimming:shemers42/auto-dimming
git switch shemers42/auto-dimming

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff shemers42/auto-dimming
git switch shemers42/auto-dimming
git rebase dev
git switch dev
git merge --ff-only shemers42/auto-dimming
git switch shemers42/auto-dimming
git rebase dev
git switch dev
git merge --no-ff shemers42/auto-dimming
git switch dev
git merge --squash shemers42/auto-dimming
git switch dev
git merge --ff-only shemers42/auto-dimming
git switch dev
git merge shemers42/auto-dimming
git push origin dev
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
conflicts

   
documentation
Improvements or additions to documentation

  
DO NOT MERGE
Work in progress not ready to be considered for merging

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
hardware
Problems or ideas about the hardware

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
conflicts
documentation
DO NOT MERGE
duplicate
enhancement
good first issue
hardware
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
greg/info-orbs!326
No description provided.