update to cover : 5Zone widget and Async HTTP requests #304 #305

Open
nconner-06 wants to merge 5 commits from nconner-06/Update_W_Clock into dev
nconner-06 commented 2025-03-20 13:52:36 +00:00 (Migrated from github.com)

5Zone widget and Async HTTP requests #304

5Zone widget and Async HTTP requests #304
lyricnz (Migrated from github.com) reviewed 2025-03-27 22:07:14 +00:00
lyricnz (Migrated from github.com) commented 2025-03-27 22:07:14 +00:00

Could be a for loop? If there can only be one match, it should break also.

Could be a for loop? If there can only be one match, it should `break` also.
nconner-06 (Migrated from github.com) reviewed 2025-03-27 22:12:05 +00:00
nconner-06 (Migrated from github.com) commented 2025-03-27 22:12:05 +00:00

yes, it could be a 'for' loop.. not sure if there's that much difference in terms of cpu and memory..

No, it should not break... There could be multiple zones with the same tzInfo, so have to check all of them..
For example, if zones 1, 2 and 5 are the same...

yes, it could be a 'for' loop.. not sure if there's that much difference in terms of cpu and memory.. No, it should not break... There could be multiple zones with the same tzInfo, so have to check all of them.. For example, if zones 1, 2 and 5 are the same...
dreed47 commented 2025-03-28 18:29:16 +00:00 (Migrated from github.com)

Could we add a persistent config variables for the offsets and on startup check to see if you already have the offset and only go to the API if you need to?

Could we add a persistent config variables for the offsets and on startup check to see if you already have the offset and only go to the API if you need to?
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nconner-06/Update_W_Clock:nconner-06/Update_W_Clock
git switch nconner-06/Update_W_Clock

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff nconner-06/Update_W_Clock
git switch nconner-06/Update_W_Clock
git rebase dev
git switch dev
git merge --ff-only nconner-06/Update_W_Clock
git switch nconner-06/Update_W_Clock
git rebase dev
git switch dev
git merge --no-ff nconner-06/Update_W_Clock
git switch dev
git merge --squash nconner-06/Update_W_Clock
git switch dev
git merge --ff-only nconner-06/Update_W_Clock
git switch dev
git merge nconner-06/Update_W_Clock
git push origin dev
Sign in to join this conversation.
No description provided.