added Morph clock type #303

Open
nconner-06 wants to merge 4 commits from nconner-06/dev_morph into dev
nconner-06 commented 2025-03-18 09:32:17 +00:00 (Migrated from github.com)

Added Morph clock type to Clock widget

I finally found time to split the Morph clock type out of my big PR (Features for ClockWidget and WeatherWidget #237) into a smaller package

Added Morph clock type to Clock widget I finally found time to split the Morph clock type out of my big PR (Features for ClockWidget and WeatherWidget #237) into a smaller package
ericthelin (Migrated from github.com) reviewed 2026-07-16 01:04:49 +00:00
ericthelin (Migrated from github.com) left a comment

I haven't gotten a chance to test this, which I would want to do before approving it. But in the mean time please update it and resolve the conflict.

I haven't gotten a chance to test this, which I would want to do before approving it. But in the mean time please update it and resolve the conflict.
@ -56,6 +56,10 @@
#define DEFAULT_CLOCK ClockType::NORMAL
ericthelin (Migrated from github.com) commented 2026-07-16 01:02:51 +00:00

I think we should maintain the order of normal then, nixie, then morph. If we keep adding clock types, which I think would be a good thing, we may need to add a more advanced architecture more like widgets where users can choose which to enable

I think we should maintain the order of normal then, nixie, then morph. If we keep adding clock types, which I think would be a good thing, we may need to add a more advanced architecture more like widgets where users can choose which to enable
nconner-06 (Migrated from github.com) reviewed 2026-07-16 19:53:03 +00:00
@ -56,6 +56,10 @@
#define DEFAULT_CLOCK ClockType::NORMAL
nconner-06 (Migrated from github.com) commented 2026-07-16 19:53:03 +00:00

It doesn't make a lot of difference to me, so switch nixie and morph in the .h file

It doesn't make a lot of difference to me, so switch nixie and morph in the .h file
This pull request has changes conflicting with the target branch.
  • firmware/config/config.h.template
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nconner-06/dev_morph:nconner-06/dev_morph
git switch nconner-06/dev_morph

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff nconner-06/dev_morph
git switch nconner-06/dev_morph
git rebase dev
git switch dev
git merge --ff-only nconner-06/dev_morph
git switch nconner-06/dev_morph
git rebase dev
git switch dev
git merge --no-ff nconner-06/dev_morph
git switch dev
git merge --squash nconner-06/dev_morph
git switch dev
git merge --ff-only nconner-06/dev_morph
git switch dev
git merge nconner-06/dev_morph
git push origin dev
Sign in to join this conversation.
No description provided.