timezone API #27

2024-06-03T22:12:10Z

tecnovel commented

2024-06-03 22:12:10 +00:00

(Migrated from github.com)

please consider the changes in config.h.template!

Trello Card: https://trello.com/c/xjwMScgJ/79-get-timezone-offset-on-boot-from-api

Changes

the globalTime class get's now the timezone offset via a seperate api so it is not depending on other widgets adn you can configure a seperate location for weather and time if you want to

**please consider the changes in config.h.template!** Trello Card: https://trello.com/c/xjwMScgJ/79-get-timezone-offset-on-boot-from-api ## Changes the globalTime class get's now the timezone offset via a seperate api so it is not depending on other widgets adn you can configure a seperate location for weather and time if you want to

ericthelin (Migrated from github.com) reviewed

2024-06-03 22:23:41 +00:00

Info-Orbs/lib/globalTime/globalTime.cpp

					
				@ -9,7 +9,6 @@ GlobalTime::GlobalTime() {

				    m_timeClient = new NTPClient(m_udp);

I don't think we need to keep the commented version around so just remove it

Info-Orbs/lib/globalTime/globalTime.cpp

					
				@ -25,8 +24,8 @@ GlobalTime *GlobalTime::getInstance() {

				void GlobalTime::updateTime() {

maybe a default value of "-1" or a constant to indicate unset?

Info-Orbs/lib/globalTime/globalTime.cpp

					
				@ -93,12 +92,29 @@ String GlobalTime::getWeekday() {

				    return m_weekday;

				}

the error should mention deserialization or something to be distinct from the http error

tecnovel (Migrated from github.com) reviewed

2024-06-04 06:28:03 +00:00

Info-Orbs/lib/globalTime/globalTime.cpp

					
				@ -25,8 +24,8 @@ GlobalTime *GlobalTime::getInstance() {

				void GlobalTime::updateTime() {

ahh, i thought -1 does not work because timezone can also be negative, but the response is already multiplied by 3600 so it should work

ericthelin (Migrated from github.com) approved these changes

2024-06-04 14:30:53 +00:00

Sign in to join this conversation.

No reviewers

ericthelin

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

greg/info-orbs!27

				`@ -9,7 +9,6 @@ GlobalTime::GlobalTime() {`
				`m_timeClient = new NTPClient(m_udp);`

				`@ -25,8 +24,8 @@ GlobalTime *GlobalTime::getInstance() {`

				`void GlobalTime::updateTime() {`

Rows
Columns