greg/info-orbs
Watch
1
0
Fork
You've already forked info-orbs
 0
Code Issues 32 Pull requests 25 Projects Releases Packages Wiki Activity Actions

WebDataWidget: 'filled' property doesnt work as expected with 'circle' #230

New issue
Open
opened 2025-01-23 19:12:49 +00:00 by bshep · 0 comments
bshep commented 2025-01-23 19:12:49 +00:00 (Migrated from github.com)
Copy link

When using a WebDataWidget and using a 'circle' element, the expected behavior if for the circle to be filled when 'filled' is set to 'true' however this only works if its set to '1', this is due to this line:

github.com/brettdottech/info-orbs@541bba9afe/firmware/src/widgets/webdatawidget/WebDataElementCircleModel.cpp (L71)

This int32_t should be replaced by bool.

When using a WebDataWidget and using a 'circle' element, the expected behavior if for the circle to be filled when 'filled' is set to 'true' however this only works if its set to '1', this is due to this line: https://github.com/brettdottech/info-orbs/blob/541bba9afe7dc77d519dd9e214ee1c211c046fd9/firmware/src/widgets/webdatawidget/WebDataElementCircleModel.cpp#L71 This `int32_t ` should be replaced by `bool`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
feature/skip-empty-stocks
main
brett-dot-tech-patch-1
No results found.
Labels
Clear labels   
bug
Something isn't working

  
conflicts

   
documentation
Improvements or additions to documentation

  
DO NOT MERGE
Work in progress not ready to be considered for merging

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
hardware
Problems or ideas about the hardware

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
conflicts
documentation
DO NOT MERGE
duplicate
enhancement
good first issue
hardware
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
greg/info-orbs#230
No description provided.